Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for trivial non-simple fields #1259

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Fixes for trivial non-simple fields #1259

merged 1 commit into from
Oct 25, 2023

Conversation

thofma
Copy link
Owner

@thofma thofma commented Oct 24, 2023

Closes #1257.

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Attention: 57 lines in your changes are missing coverage. Please review.

Comparison is base (d8aa190) 74.55% compared to head (5e9abba) 74.53%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1259      +/-   ##
==========================================
- Coverage   74.55%   74.53%   -0.03%     
==========================================
  Files         346      346              
  Lines      110993   110967      -26     
==========================================
- Hits        82756    82712      -44     
- Misses      28237    28255      +18     
Files Coverage Δ
src/AlgAss/AlgAss.jl 87.24% <100.00%> (ø)
src/AlgAss/Elem.jl 89.89% <ø> (ø)
src/AlgAssAbsOrd/LocallyFreeClassGroup.jl 92.30% <100.00%> (ø)
src/AlgAssAbsOrd/Order.jl 80.38% <100.00%> (-0.51%) ⬇️
src/EllCrv/EllCrv.jl 95.57% <100.00%> (ø)
src/EllCrv/Finite.jl 94.61% <100.00%> (+0.17%) ⬆️
src/EllCrv/Heights.jl 92.43% <100.00%> (ø)
src/EllCrv/Isogeny.jl 90.68% <100.00%> (ø)
src/EllCrv/Isomorphisms.jl 90.85% <100.00%> (ø)
src/FunField/Factor.jl 43.79% <100.00%> (ø)
... and 55 more

... and 22 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thofma thofma merged commit 57654c6 into master Oct 25, 2023
12 of 16 checks passed
@thofma thofma deleted the th/1257 branch October 25, 2023 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Silly example of a non-simple number field
1 participant