Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename mul to * #1243

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Rename mul to * #1243

merged 3 commits into from
Oct 18, 2023

Conversation

lgoettgens
Copy link
Contributor

Resolves #1226.

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (6d81413) 74.54% compared to head (a27097b) 74.53%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1243      +/-   ##
==========================================
- Coverage   74.54%   74.53%   -0.01%     
==========================================
  Files         346      346              
  Lines      110838   111006     +168     
==========================================
+ Hits        82627    82743     +116     
- Misses      28211    28263      +52     
Files Coverage Δ
src/Deprecations.jl 4.54% <ø> (ø)
src/Sparse/Matrix.jl 69.60% <100.00%> (ø)
src/Sparse/Solve.jl 85.97% <100.00%> (ø)
src/NumFieldOrd/NfOrd/Clgp/Map.jl 79.40% <0.00%> (-3.80%) ⬇️
src/NumFieldOrd/NfOrd/Clgp/cm_field.jl 0.00% <0.00%> (ø)
src/NumField/NfAbs/NormRelation/SUnits.jl 67.46% <33.33%> (ø)
src/Misc/MSet.jl 96.23% <98.58%> (+46.49%) ⬆️

... and 35 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/Deprecations.jl Outdated Show resolved Hide resolved
@StevellM StevellM merged commit d8aa190 into thofma:master Oct 18, 2023
13 of 16 checks passed
@lgoettgens lgoettgens deleted the lg/mul branch October 18, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mul vs. * for sparse matrices
3 participants