Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate field_of_fractions(O::GenOrd) #1240

Merged
merged 3 commits into from
Oct 12, 2023
Merged

deprecate field_of_fractions(O::GenOrd) #1240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f1c441
deprecate field_of_fractions
felix-roehrich Oct 10, 2023
1747129
add call signature
felix-roehrich Oct 10, 2023
c426b72
move deprecation
felix-roehrich Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Deprecations.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,9 @@

@deprecate any_root(f::Hecke.AbstractAlgebra.Generic.Poly, F::Hecke.RelFinField) any_root(F, f)

# Deprecated during 0.22.*

@deprecate field_of_fractions(O::GenOrd) function_field(O::GenOrd)

# Things that moved to Nemo

Expand Down
5 changes: 0 additions & 5 deletions src/FunField/Divisor.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,15 +171,10 @@ function ideals(D)
end

@doc raw"""
field_of_fractions(O::GenOrd) -> FunctionField
function_field(O::GenOrd) -> FunctionField

Return the function field of O.
"""
function field_of_fractions(O::GenOrd)
return O.F
end

function function_field(O::GenOrd)
return O.F
end
Expand Down
Loading