Remove unnecessary tests #1237
Merged
Remove unnecessary tests #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't see what purposes these tests are meant to serve. Also they lead
to a warning ("WARNING: Method definition change_base_ring ...
overwritten ..."), and potentially change the behavior of later tests.
thofma
reviewed
Oct 9, 2023
|
I will wait for this and then tag a new version. |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1237 +/- ##
==========================================
- Coverage 74.49% 74.47% -0.02%
==========================================
Files 346 346
Lines 110846 110846
==========================================
- Hits 82576 82555 -21
- Misses 28270 28291 +21 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't see what purposes these tests are meant to serve. Also they lead to a warning ("WARNING: Method definition change_base_ring ... overwritten ..."), and potentially change the behavior of later tests.
Resolves #1235
@thofma added this in PR #139.