Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from FiniteField to finite_field #1231

Merged
merged 1 commit into from
Oct 8, 2023

Switch from FiniteField to finite_field

379ee51
Select commit
Loading
Failed to load commit list.
Merged

Switch from FiniteField to finite_field #1231

Switch from FiniteField to finite_field
379ee51
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 4, 2023 in 1s

74.56% (+0.09%) compared to 8f64388

View this Pull Request on Codecov

74.56% (+0.09%) compared to 8f64388

Details

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (8f64388) 74.46% compared to head (379ee51) 74.56%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1231      +/-   ##
==========================================
+ Coverage   74.46%   74.56%   +0.09%     
==========================================
  Files         346      346              
  Lines      110830   110994     +164     
==========================================
+ Hits        82534    82761     +227     
+ Misses      28296    28233      -63     
Files Coverage Δ
src/GenOrd/Ideal.jl 78.32% <100.00%> (ø)
src/LocalField/LocalField.jl 74.46% <100.00%> (ø)
src/LocalField/qAdic.jl 76.11% <100.00%> (ø)
src/Misc/Poly.jl 62.11% <ø> (ø)
src/Misc/RelFiniteField.jl 73.47% <100.00%> (ø)
src/NumField/NfAbs/Simplify.jl 89.47% <100.00%> (ø)
src/NumFieldOrd/NfOrd/Hensel.jl 86.22% <ø> (ø)
src/NumFieldOrd/NfOrd/Ideal/Prime.jl 82.56% <100.00%> (+0.55%) ⬆️
src/NumFieldOrd/NfOrd/MaxOrd/Polygons.jl 89.17% <100.00%> (ø)
src/QuadForm/Quad/NormalForm.jl 99.70% <100.00%> (ø)
... and 2 more

... and 30 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.