Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax some signatures #1217

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Relax some signatures #1217

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/NumFieldOrd/NfOrd/Ideal/Prime.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,15 +227,15 @@ $\mathfrak p$ with $l \leq \deg(\mathfrak p)$ will be returned.
Note that in this case it may happen that $p\mathcal O$ is not the product of the
$\mathfrak p_i^{e_i}$.
"""
function prime_decomposition(O::NfAbsOrd{NfAbsNS, NfAbsNSElem}, p::IntegerUnion, degree_limit::Int = degree(O), lower_limit::Int = 0; cached::Bool = true)
function prime_decomposition(O::NfAbsOrd{<:NumField{QQFieldElem}, <:Any}, p::IntegerUnion, degree_limit::Int = degree(O), lower_limit::Int = 0; cached::Bool = true)
if typeof(p) != Int && fits(Int, p)
return prime_decomposition(O, Int(p), degree_limit, lower_limit, cached = cached)
end
if typeof(p) != ZZRingElem && typeof(p) != Int
return prime_decomposition(O, ZZRingElem(p), degree_limit, lower_limit, cached = cached)
end

if !divisible(numerator(discriminant(nf(O))), p)
if (nf(O) isa NfAbsNS || nf(O) isa AnticNumberField) && !divisible(numerator(discriminant(nf(O))), p)
return prime_dec_nonindex(O, p, degree_limit, lower_limit)
else
return prime_dec_gen(O, p, degree_limit, lower_limit)
Expand Down