Add some tweaks for type stability etc. #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several changes deal with JET warnings about "captured variables" resulting in disabled optimizations resp. type unstable code. E.g. `mFF` was assigned different values in two places which then are referenced inside closures. Likewise, `NN` was used in lambdas, which we now avoid.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1214 +/- ##
==========================================
+ Coverage 74.41% 74.48% +0.06%
==========================================
Files 346 346
Lines 110798 110949 +151
==========================================
+ Hits 82451 82639 +188
+ Misses 28347 28310 -37
☔ View full report in Codecov by Sentry. |
|
Breaking Oscar |
|
Indeed, it breaks experimental code: Fix submitted as oscar-system/Oscar.jl#2814 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several changes deal with JET warnings about "captured variables"
resulting in disabled optimizations resp. type unstable code.
E.g.
mFFwas assigned different values in two places which thenare referenced inside closures.
Likewise,
NNwas used in lambdas, which we now avoid.