Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pretty printing for HeckeMap #1213

Merged
merged 1 commit into from
Sep 19, 2023
Merged

pretty printing for HeckeMap #1213

merged 1 commit into from
Sep 19, 2023

Conversation

simonbrandhorst
Copy link
Collaborator

No description provided.

@simonbrandhorst
Copy link
Collaborator Author

Will break doctests in Oscar.

@codecov
Copy link

codecov bot commented Sep 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04% 🎉

Comparison is base (84fe6d0) 74.41% compared to head (7e495fb) 74.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1213      +/-   ##
==========================================
+ Coverage   74.41%   74.45%   +0.04%     
==========================================
  Files         346      346              
  Lines      110798   110797       -1     
==========================================
+ Hits        82451    82496      +45     
+ Misses      28347    28301      -46     
Files Changed Coverage Δ
src/Map/MapType.jl 98.93% <100.00%> (-0.02%) ⬇️

... and 29 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thofma
Copy link
Owner

thofma commented Sep 19, 2023

I find it a bit confusing, to do a println(f) in the doctest, just so that some other printing is tested.

@thofma thofma merged commit 3827bb4 into master Sep 19, 2023
13 of 16 checks passed
@thofma thofma deleted the sb/pretty_print_maps branch September 19, 2023 06:55
@simonbrandhorst
Copy link
Collaborator Author

So you suggest calling show(X) instead? Will do next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants