Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Towards non-nice relative number fields #1209

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Towards non-nice relative number fields #1209

merged 1 commit into from
Sep 15, 2023

Conversation

thofma
Copy link
Owner

@thofma thofma commented Sep 14, 2023

No description provided.

@thofma
Copy link
Owner Author

thofma commented Sep 14, 2023

@fieker This only introduces the any_order for relative extensions. It does not fix the maximal order yet.

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 76.36% and project coverage change: -0.11% ⚠️

Comparison is base (bb78886) 74.44% compared to head (bd0e035) 74.33%.
Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1209      +/-   ##
==========================================
- Coverage   74.44%   74.33%   -0.11%     
==========================================
  Files         346      346              
  Lines      110743   110798      +55     
==========================================
- Hits        82442    82362      -80     
- Misses      28301    28436     +135     
Files Changed Coverage Δ
src/NumField/NfRel/NfRel.jl 78.55% <ø> (-0.10%) ⬇️
src/NumField/NfRel/NfRelNS.jl 83.53% <ø> (ø)
src/NumFieldOrd/NfOrd/NfOrd.jl 84.83% <0.00%> (-0.93%) ⬇️
src/NumFieldOrd/NfOrd/Ideal/Prime.jl 82.00% <25.00%> (-0.78%) ⬇️
src/NumField/NfAbs/Elem.jl 68.12% <50.00%> (-0.27%) ⬇️
src/NumFieldOrd/NfRelOrd/NfRelOrd.jl 83.29% <94.44%> (+0.70%) ⬆️
src/NumField/Elem.jl 91.36% <100.00%> (+0.20%) ⬆️
src/NumFieldOrd/NfOrd/ResidueField.jl 88.59% <100.00%> (ø)

... and 35 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thofma thofma merged commit 84fe6d0 into master Sep 15, 2023
13 of 16 checks passed
@thofma thofma deleted the th/nonnice branch September 15, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant