-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let AbsAlgAss
no longer be a Ring
#1206
Conversation
I am unsure what else from #441 needs to be reverted. |
Lets wait for the tests |
|
Yes, correct |
This needs a few more changes in AbstractAlgebra (Nemocas/AbstractAlgebra.jl#1423). The relevant test files succeed locally (with Nemocas/AbstractAlgebra.jl#1423 and Nemocas/Nemo.jl#1531 deved in). I am currently running the full testsuite locally. |
I think this needs to be restarted once #1208 is merged. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1206 +/- ##
==========================================
- Coverage 74.44% 74.43% -0.01%
==========================================
Files 346 346
Lines 110747 110745 -2
==========================================
- Hits 82442 82434 -8
- Misses 28305 28311 +6
☔ View full report in Codecov by Sentry. |
Fixes #1139.
Let's see if anything breaks. If not, I see no reason not to change this.
However, I would classify this a breaking change.