Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let AbsAlgAss no longer be a Ring #1206

Merged
merged 7 commits into from
Sep 14, 2023
Merged

Conversation

lgoettgens
Copy link
Contributor

Fixes #1139.

Let's see if anything breaks. If not, I see no reason not to change this.
However, I would classify this a breaking change.

@lgoettgens
Copy link
Contributor Author

I am unsure what else from #441 needs to be reverted.

@thofma
Copy link
Owner

thofma commented Sep 11, 2023

Lets wait for the tests

@lgoettgens
Copy link
Contributor Author

AlgAssAbsOrd and AlgAssRelOrd then must be changed from <: Ring to <: NCRing as well, right? @thofma

@thofma
Copy link
Owner

thofma commented Sep 11, 2023

Yes, correct

@lgoettgens
Copy link
Contributor Author

lgoettgens commented Sep 12, 2023

This needs a few more changes in AbstractAlgebra (Nemocas/AbstractAlgebra.jl#1423). The relevant test files succeed locally (with Nemocas/AbstractAlgebra.jl#1423 and Nemocas/Nemo.jl#1531 deved in). I am currently running the full testsuite locally.

@thofma thofma closed this Sep 13, 2023
@thofma thofma reopened this Sep 13, 2023
@lgoettgens
Copy link
Contributor Author

I think this needs to be restarted once #1208 is merged.

@thofma thofma closed this Sep 14, 2023
@thofma thofma reopened this Sep 14, 2023
@lgoettgens lgoettgens closed this Sep 14, 2023
@lgoettgens lgoettgens reopened this Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (1cf978a) 74.44% compared to head (ddc2491) 74.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1206      +/-   ##
==========================================
- Coverage   74.44%   74.43%   -0.01%     
==========================================
  Files         346      346              
  Lines      110747   110745       -2     
==========================================
- Hits        82442    82434       -8     
- Misses      28305    28311       +6     
Files Changed Coverage Δ
src/AlgAssAbsOrd/Ideal.jl 74.91% <ø> (ø)
src/AlgAssAbsOrd/Order.jl 80.88% <ø> (ø)
src/AlgAssAbsOrd/Types.jl 89.10% <ø> (ø)
src/AlgAssRelOrd/Types.jl 86.79% <ø> (ø)
src/AlgAss/AlgMat.jl 87.75% <100.00%> (ø)
src/AlgAss/Types.jl 87.50% <100.00%> (+1.13%) ⬆️

... and 35 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thofma thofma merged commit 329a04b into thofma:master Sep 14, 2023
@lgoettgens lgoettgens deleted the lg/AlgQuat branch September 14, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quaternion algebra is commutative?
2 participants