Move obvious type piracy from Hecke to Nemo #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
force-pushed
the
lg/hecke-piracy
branch
4 times, most recently
from
6a89741 to
28c4e1e
Compare
lgoettgens
force-pushed
the
lg/hecke-piracy
branch
from
28c4e1e to
854a1bb
Compare
lgoettgens
added a commit
to lgoettgens/Hecke.jl
that referenced
this pull request
Jul 6, 2023
lgoettgens
added a commit
to lgoettgens/Hecke.jl
that referenced
this pull request
Jul 6, 2023
lgoettgens
added a commit
to lgoettgens/Hecke.jl
that referenced
this pull request
Jul 6, 2023
thofma
pushed a commit
that referenced
this pull request
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the removals necessary after Nemocas/Nemo.jl#1501. Both PRs together resolve parts of #1126.
CI is expected to fail here until Nemocas/Nemo.jl#1501 is available.