Fix multiplication

thofma · Sep 21, 2023 · d9ca7a5 · d9ca7a5
1 parent aeb3f9b
commit d9ca7a5
Showing 1 changed file with 10 additions and 11 deletions.
diff --git a/src/Sparse/Matrix.jl b/src/Sparse/Matrix.jl
@@ -691,37 +691,36 @@ end
 #
 ################################################################################
 
-function *(b::T, A::SMat{T}) where T
-  B = sparse_matrix(base_ring(A), nrows(A), ncols(A))
+function *(b::T, A::SMat{T}) where {T}
   if iszero(b)
-    return B
+    return sparse_matrix(base_ring(A), nrows(A), ncols(A))
   end
+  B = sparse_matrix(base_ring(A), 0, ncols(A))
   for a in A
-    push!(B, b*a)
+    push!(B, b * a)
   end
   return B
 end
 
 function *(b, A::SMat)
-  return base_ring(A)(b)*A
+  return base_ring(A)(b) * A
 end
 
-function *(A::SMat{T}, b::T) where T
-  B = sparse_matrix(base_ring(A), nrows(A), ncols(A))
+function *(A::SMat{T}, b::T) where {T}
   if iszero(b)
-    return B
+    return sparse_matrix(base_ring(A), nrows(A), ncols(A))
   end
+  B = sparse_matrix(base_ring(A), 0, ncols(A))
   for a in A
-    push!(B, a*b)
+    push!(B, a * b)
   end
   return B
 end
 
 function *(A::SMat, b)
-  return A*base_ring(A)(b)
+  return A * base_ring(A)(b)
 end
 
-
 ################################################################################
 #
 #  Submatrix