Minor cleanup related to FacElemMon and FacElem (#1693)

FacElemMon is a monoid, not a ring
thofma · Dec 4, 2024 · cd361f4 · cd361f4
1 parent fb22ad4
commit cd361f4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/HeckeTypes.jl b/src/HeckeTypes.jl
@@ -593,7 +593,7 @@ end
 
 Parent for factored elements, ie. power products.
 """
-mutable struct FacElemMon{S} <: Ring
+mutable struct FacElemMon{S}
   base_ring::S  # for the base
   basis_conjugates_log::Dict{RingElem, Tuple{Int, Vector{ArbFieldElem}}}
   basis_conjugates::Dict{RingElem, Tuple{Int, Vector{ArbFieldElem}}}
@@ -631,6 +631,8 @@ end
 
 FacElemMon(R::S) where {S} = FacElemMon{S}(R)
 
+const FacElemMonDict = AbstractAlgebra.CacheDictType()
+
 """
     FacElem{B, S}
 

diff --git a/src/Misc/FactoredElem.jl b/src/Misc/FactoredElem.jl
@@ -69,8 +69,6 @@ end
 
 # abstract nonsense
 
-const FacElemMonDict = AbstractAlgebra.CacheDictType{Ring, FacElemMon}()
-
 function (x::FacElemMon{S})() where S
   z = FacElem{elem_type(S), S}()
   z.fac = Dict{elem_type(S), ZZRingElem}()