Remove wildly general check_parent (#1205)

* Experiment: remove wildly general `check_parent` * Fix `+(::GenOrdIdl, ::GenOrdIdl)`
thofma · Sep 13, 2023 · c591959 · c591959
1 parent 7fc2453
commit c591959
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/src/GenOrd/Ideal.jl b/src/GenOrd/Ideal.jl
@@ -251,8 +251,7 @@ end
 
 
 function Base.:(+)(a::GenOrdIdl, b::GenOrdIdl)
-  check_parent(a, b)
-  O = order(a)
+  @req order(a) === order(b) "Ideals must have same order"
 
   if iszero(a)
     return b

diff --git a/src/NumField/NfRel/NfRel.jl b/src/NumField/NfRel/NfRel.jl
@@ -443,10 +443,6 @@ function add!(c::NfRelElem{T}, a::NfRelElem{T}, b::NfRelElem{T}) where {T}
   return c
 end
 
-function check_parent(a, b)
-  return a==b
-end
-
 ################################################################################
 #
 #  Hash function