Uniform base_field_type handling

Also remove redundant dense_poly_type methods.
thofma · Dec 19, 2024 · 88eed80 · 88eed80
1 parent 9f4ccb9
commit 88eed80
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 10 deletions.
diff --git a/src/Hecke.jl b/src/Hecke.jl
@@ -556,6 +556,8 @@ order_type(T::DataType) = throw(MethodError(order_type, (T,)))
 embedding_type(x) = embedding_type(typeof(x))
 embedding_type(T::DataType) = throw(MethodError(embedding_type, (T,)))
 
+base_field_type(x) = base_field_type(typeof(x))
+base_field_type(T::DataType) = throw(MethodError(base_field_type, (T,)))
 
 ################################################################################
 #

diff --git a/src/LocalField/LocalField.jl b/src/LocalField/LocalField.jl
@@ -37,14 +37,10 @@ prime(K::LocalField) = prime(base_field(K))
 #
 ################################################################################
 
-base_field_type(K::LocalField{S, T}) where {S <: FieldElem, T <: LocalFieldParameter} = parent_type(S)
 base_field_type(::Type{LocalField{S, T}}) where {S <: FieldElem, T <: LocalFieldParameter} = parent_type(S)
 
 elem_type(::Type{LocalField{S, T}}) where {S <: FieldElem, T <: LocalFieldParameter} = LocalFieldElem{S, T}
 
-dense_poly_type(K::LocalField{S, T}) where {S <: FieldElem, T <: LocalFieldParameter} = Generic.Poly{LocalFieldElem{S, T}}
-dense_poly_type(::Type{LocalField{S, T}}) where {S <: FieldElem, T <: LocalFieldParameter} = Generic.Poly{LocalFieldElem{S, T}}
-
 ################################################################################
 #
 #  Basic predicates

diff --git a/src/Map/NumField.jl b/src/Map/NumField.jl
@@ -182,13 +182,9 @@ end
 #
 ################################################################################
 
-base_field_type(::AbsSimpleNumField) = QQField
+base_field_type(::Type{AbsSimpleNumField}) = QQField
 
-base_field_type(::AbsNonSimpleNumField) = QQField
-
-base_field_type(::RelSimpleNumField{T}) where {T} = parent_type(T)
-
-base_field_type(::RelNonSimpleNumField{T}) where {T} = parent_type(T)
+base_field_type(::Type{AbsNonSimpleNumField}) = QQField
 
 base_field_type(::Type{RelNonSimpleNumField{T}}) where {T} = parent_type(T)
 

diff --git a/src/Misc/RelFiniteField.jl b/src/Misc/RelFiniteField.jl
@@ -56,6 +56,8 @@ function defining_polynomial(F::RelFinField{T}) where T
   return F.defining_polynomial::dense_poly_type(T)
 end
 
+base_field_type(::Type{RelFinField{S}}) where S = parent_type(S)
+
 base_field(F::RelFinField{S}) where S= base_ring(F.defining_polynomial)::parent_type(S)
 
 characteristic(F::RelFinField) = characteristic(base_field(F))