ideal_type is provided by AA 0.44.0

thofma · Dec 16, 2024 · 7764edb · 7764edb
1 parent 9f4ccb9
commit 7764edb
Showing 1 changed file with 0 additions and 8 deletions.
diff --git a/src/Hecke.jl b/src/Hecke.jl
@@ -536,14 +536,6 @@ Base.showerror(io::IO, ::NotImplemented) =
 function is_absolutely_irreducible end
 function multiplicative_group end
 
-
-# TODO: once https://github.com/Nemocas/AbstractAlgebra.jl/pull/1924 lands
-# and we require an AA version with it, remove the next four lines
-if !isdefined(AbstractAlgebra, :ideal_type)
-  ideal_type(x) = ideal_type(typeof(x))
-  ideal_type(T::DataType) = throw(MethodError(ideal_type, (T,)))
-end
-
 fractional_ideal_type(x) = fractional_ideal_type(typeof(x))
 fractional_ideal_type(T::DataType) = throw(MethodError(fractional_ideal_type, (T,)))