issquare_with_root -> issquare_with_square_root

thofma · Jan 26, 2021 · 6f703f8 · 6f703f8
1 parent 6ce6e11
commit 6f703f8
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/Misc/Integer.jl b/src/Misc/Integer.jl
@@ -497,19 +497,19 @@ function issquare(x::fmpq)
   return x > 0 && issquare(numerator(x)) && issquare(denominator(x))
 end
 
-function issquare_with_root(x::fmpq)
+function issquare_with_square_root(x::fmpq)
   if x < 0
     return false, x
   else
-    fl, n = issquare_with_root(numerator(x))
+    fl, n = issquare_with_square_root(numerator(x))
     !fl && return false, x
-    fl, d = issquare_with_root(denominator(x))
+    fl, d = issquare_with_square_root(denominator(x))
     !fl && return false, x
     return true, fmpq(n, d)
   end
 end
 
-function issquare_with_root(x::fmpz)
+function issquare_with_square_root(x::fmpz)
   if !issquare(x)
     return false, x
   else

diff --git a/src/NumField/NfAbs/Elem.jl b/src/NumField/NfAbs/Elem.jl
@@ -840,7 +840,7 @@ Tests if $a$ is a square and return the root if possible.
 """
 issquare(a::nf_elem) = ispower(a, 2)
 
-issquare_with_root(a::NumFieldElem) = issquare(a)
+issquare_with_square_root(a::NumFieldElem) = issquare(a)
 
 @doc Markdown.doc"""
     sqrt(a::nf_elem) -> nf_elem

diff --git a/src/QuadForm/Quad/Spaces.jl b/src/QuadForm/Quad/Spaces.jl
@@ -1140,7 +1140,7 @@ function _isisotropic_with_vector(F::MatrixElem)
     end
   end
 
-  fl, y = issquare_with_root(-D[1]//D[2])
+  fl, y = issquare_with_square_root(-D[1]//D[2])
   if fl
     return true, elem_type(K)[T[1, k] + y * T[2, k] for k in 1:ncols(T)]
   elseif length(D) == 2