Collect _copy_matrix_into_matrix methods, fix name of one (#1541)

Now all _copy_matrix_into_matrix are next to each other and the
one for QQMatrix has the right name

src/Misc/Matrix.jl

@@ -336,7 +336,7 @@ function _copy_matrix_into_matrix(A::ZZMatrix, i::Int, j::Int, B::ZZMatrix)
   end
 end
 
-function _copy_matrix_into_matrix!(A::QQMatrix, i::Int, j::Int, B::QQMatrix)
+function _copy_matrix_into_matrix(A::QQMatrix, i::Int, j::Int, B::QQMatrix)
   @GC.preserve A B begin
     for k in 0:nrows(B) - 1
       for l in 0:ncols(B) - 1
@@ -348,6 +348,15 @@ function _copy_matrix_into_matrix!(A::QQMatrix, i::Int, j::Int, B::QQMatrix)
   end
 end
 
+function _copy_matrix_into_matrix(A::MatElem, i::Int, j::Int, B::MatElem)
+  for k in 0:nrows(B) - 1
+    for l in 0:ncols(B) - 1
+      setindex!(A, B[k+1, l+1], i+k, j+l)
+    end
+  end
+  return nothing
+end
+
 function _copy_matrix_into_matrix(A::MatElem, r::Vector{Int}, c::Vector{Int}, B::MatElem)
   for i = 1:length(r)
     for j = 1:length(c)

src/Misc/jordan.jl

@@ -126,15 +126,6 @@ function decompose_primary(M::MatElem{T}) where T <: FieldElem
   return L
 end
 
-function _copy_matrix_into_matrix(A::MatElem, i::Int, j::Int, B::MatElem)
-  for k in 0:nrows(B) - 1
-    for l in 0:ncols(B) - 1
-      setindex!(A, B[k+1, l+1], i+k, j+l)
-    end
-  end
-  return nothing
-end
-
 
 @doc raw"""
     companion_matrix(p::PolyRingElem) -> MatElem

test/Misc/Matrix.jl

@@ -9,8 +9,8 @@
   A = QQ[1 2; 3 4]
   B = QQ[1;]
   Z = zero_matrix(QQ, 3, 3)
-  Hecke._copy_matrix_into_matrix!(Z, 1, 1, A)
-  Hecke._copy_matrix_into_matrix!(Z, 3, 3, B)
+  Hecke._copy_matrix_into_matrix(Z, 1, 1, A)
+  Hecke._copy_matrix_into_matrix(Z, 3, 3, B)
   @test Z == diagonal_matrix(A, B)
 
   A = ZZ[1 2; 3 4]