isfree: fix another book-example (#1450)

* isfree: fix another book-example support local_freeness in _is_principal_with_data_bj
thofma · Apr 10, 2024 · 4e55aec · 4e55aec
1 parent 3c31def
commit 4e55aec
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/AlgAssAbsOrd/PIP/bley_johnston.jl b/src/AlgAssAbsOrd/PIP/bley_johnston.jl
@@ -158,7 +158,8 @@ function __unit_reps(M, F)
   return unit_reps
 end
 
-function _is_principal_with_data_bj(I, O; side = :right, _alpha = nothing)
+function _is_principal_with_data_bj(I, O; side = :right, _alpha = nothing, local_freeness::Bool = false)
+  # local_freeness needs to be accepted since the generic interface uses it
   A = algebra(O)
   if _alpha === nothing
     _assert_has_refined_wedderburn_decomposition(A)

diff --git a/test/ModAlgAss/Lattices/Lattices.jl b/test/ModAlgAss/Lattices/Lattices.jl
@@ -13,3 +13,12 @@ begin
   V, f = galois_module(K); OK = ring_of_integers(K); M = f(OK);
   @test !is_free(M)
 end
+
+let
+  Qx, x = QQ["x"]
+  K, a = number_field(x^8 + 105*x^6 + 3465*x^4 + 44100*x^2 + 176400, "a")
+  V, f = galois_module(K)
+  OK = ring_of_integers(K)
+  M = f(OK)
+  @test !is_free(M)
+end