Skip to content

Commit

Permalink
more
Browse files Browse the repository at this point in the history
  • Loading branch information
thofma committed Nov 14, 2024
1 parent ddf1e30 commit 15be127
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/FunField/HessQR.jl
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,8 @@ function expressify(a::HessQRElem; context = nothing)
expressify(a.g, context = context)))
end

Hecke.characteristic(::HessQR) = 0

Check warning on line 114 in src/FunField/HessQR.jl

View check run for this annotation

Codecov / codecov/patch

src/FunField/HessQR.jl#L114

Added line #L114 was not covered by tests

function Hecke.integral_split(a::Generic.RationalFunctionFieldElem{QQFieldElem}, S::HessQR)
if iszero(a)
return zero(S), one(S)
Expand Down
2 changes: 2 additions & 0 deletions src/NumField/NfAbs/Elem.jl
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,8 @@ end

#In this version, n is supposed to be a prime power
function is_norm_divisible_pp(a::AbsSimpleNumFieldElem, n::ZZRingElem)
Main.a = a
Main.n = n
K = parent(a)
if !is_coprime(denominator(K.pol), n)
na = norm(a)
Expand Down
1 change: 1 addition & 0 deletions src/NumFieldOrd/NfOrd/MaxOrd/Polygons.jl
Original file line number Diff line number Diff line change
Expand Up @@ -741,6 +741,7 @@ function _decomposition(O::AbsNumFieldOrder, I::AbsNumFieldOrderIdeal, Ip::AbsNu
Ba = basis(P, copy = false)
for i in 1:degree(O)
if !is_norm_divisible_pp((v*Ba[i] + u).elem_in_nf, modulo)
@assert !is_zero(mod(ZZ(norm((v*Ba[i] + u).elem_in_nf)), modulo))
u = v*Ba[i] + u
break
end
Expand Down

0 comments on commit 15be127

Please sign in to comment.