You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
Thinking about this, this would break if someone was trying to simulate that a value is actually undefined.
Maybe it'd be better to have some better way of detecting if a property exists on the object or any of it's prototypes, even if it's undefined.
16f66f3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thlorenz This should go out in a patch release when you have a chance. Fixes the iojs issue with
fs
without needing to check the property descriptor.16f66f3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking about this, this would break if someone was trying to simulate that a value is actually
undefined
.Maybe it'd be better to have some better way of detecting if a property exists on the object or any of it's prototypes, even if it's
undefined
.16f66f3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At any rate it's an improvement and I'll pull it in and publish.
16f66f3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Published - thanks :)
16f66f3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be
for key in mdl
then. Wanna do that?16f66f3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well as long as it works with prototype chain. That was basically something I wasn't/am not sure of.