-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit linkHeader length, throw error if exceeds #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please introduce those env vars and consider them in the code.
Additionally please add tests for this behavior as well as document the changes along with the env vars allowing to configure this.
Aside from that LGTM
Hi @thlorenz ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the nits/changes I found/requested.
1a2d021
to
d6f7971
Compare
Done :) |
Hi @thlorenz , did you get a chance to look at the changes? |
Currently swamped (new job) .. give me a week please. |
Hi @thlorenz , did you get a chance to look at the changes? let me know if I can help in any way! (also hope you're enjoying the new job!) |
Hey thanks for all the work and patience .. I've been super swamped with things lately but am still aware of this request. |
Published as 2.0 (new major since this is a major behavior change). Thanks! |
This limits the length of the
linkHeader
, and throws an error if the length exceeds a threshold (currently 2000, can change if needed).