Bump Traceur to version 0.0.90 #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| names: [], | ||
| mappings: sourceMap.mappings, | ||
| sourceRoot: sourceRootConverted, | ||
| sourcesContent: [ |
There was a problem hiding this comment.
So as far as I can tell this removes all our test coverage for source maps, which was the main sticking point in previous PRs :(. We can't break that...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps Traceur to the most recent version (right now 0.0.90).
All tests pass (I had to modify a few, but I ensured that none of that changes removed tests for API features that es6ify used).
I know this has been discussed in #79 and a fix was started in #80. I'm not well versed in es6ify or traceur internals, but the last discussion here was about 0.0.82, so perhaps more API changes have happened that now make es6ify's version bump more seamless.
To confirm that es6ify still works (beyond the safety of the tests), I went into a few of my projects that use es6ify and dropped in this new version. Everything compiled (and the projects still ran in browser).
Of course, I welcome any feedback, if there is an es6ify behavior that I've broken with this PR. I'll try my best to sort it out.
Thanks for maintaining this project! It's really useful to browserify community!