Skip to content

Commit

Permalink
Clarify custom keycode enum requirement for PRs (qmk#21648)
Browse files Browse the repository at this point in the history
  • Loading branch information
3geek14 authored and thismarvin committed Sep 27, 2023
1 parent 96a1010 commit 86c04ac
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion docs/pr_checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ If there are any inconsistencies with these recommendations, you're best off [cr

- `#include QMK_KEYBOARD_H` preferred to including specific board files
- prefer layer `enum`s to `#define`s
- require custom keycode `enum`s to `#define`s, first entry must have ` = SAFE_RANGE`
- custom keycode `enum`s must have first entry `= SAFE_RANGE`
- terminating backslash (`\`) in lines of LAYOUT macro parameters is superfluous and should be removed
- some care with spacing (e.g., alignment on commas or first char of keycodes) makes for a much nicer-looking keymap

Expand Down

0 comments on commit 86c04ac

Please sign in to comment.