apacheGH-39845: [C++][Parquet] Minor: avoid creating a new Reader obj…

…ect in Decoder::SetData (apache#39847) ### Rationale for this change avoid creating a new Reader object in Decoder::SetData ### What changes are included in this PR? avoid creating a new Reader object in Decoder::SetData ### Are these changes tested? Already ### Are there any user-facing changes? no * Closes: apache#39845 Authored-by: mwish <[email protected]> Signed-off-by: mwish <[email protected]>
thisisnic · Mar 8, 2024 · c6a9bfb · c6a9bfb
1 parent 213d82d
commit c6a9bfb
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/cpp/src/parquet/encoding.cc b/cpp/src/parquet/encoding.cc
@@ -2411,7 +2411,11 @@ class DeltaBitPackDecoder : public DecoderImpl, virtual public TypedDecoder<DTyp
   void SetData(int num_values, const uint8_t* data, int len) override {
     // num_values is equal to page's num_values, including null values in this page
     this->num_values_ = num_values;
-    decoder_ = std::make_shared<::arrow::bit_util::BitReader>(data, len);
+    if (decoder_ == nullptr) {
+      decoder_ = std::make_shared<::arrow::bit_util::BitReader>(data, len);
+    } else {
+      decoder_->Reset(data, len);
+    }
     InitHeader();
   }
 
@@ -2769,7 +2773,11 @@ class DeltaLengthByteArrayDecoder : public DecoderImpl,
 
   void SetData(int num_values, const uint8_t* data, int len) override {
     DecoderImpl::SetData(num_values, data, len);
-    decoder_ = std::make_shared<::arrow::bit_util::BitReader>(data, len);
+    if (decoder_ == nullptr) {
+      decoder_ = std::make_shared<::arrow::bit_util::BitReader>(data, len);
+    } else {
+      decoder_->Reset(data, len);
+    }
     DecodeLengths();
   }