-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Improve ERC721 claimToBatch #5257
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5257 +/- ##
=======================================
Coverage 45.36% 45.36%
=======================================
Files 1067 1067
Lines 55434 55433 -1
Branches 3991 3991
=======================================
+ Hits 25147 25148 +1
+ Misses 29596 29594 -2
Partials 691 691
*This pull request uses carry forward flags. Click here to find out more.
|
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR refactors the validation logic in the
claimToBatch.ts
file to improve error handling for missing recipient addresses and claim quantities. It replaces the use offindIndex
with afor
loop for more straightforward validation.Detailed summary
findIndex
for checking missing recipient addresses and claim quantities.for
loop to iterate throughoptions.content
for validation.