Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enum lint warning in dashboard #5234

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Oct 30, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on refactoring the usage of AccountStatus and AccountPlan enums to constant objects (accountStatus and accountPlan) throughout the codebase, improving consistency and readability.

Detailed summary

  • Replaced AccountStatus enum with accountStatus object in multiple files.
  • Replaced AccountPlan enum with accountPlan object in various components.
  • Updated conditions and checks to use the new constant objects.
  • Ensured all relevant logic reflects the changes in account status and plan handling.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Oct 30, 2024

⚠️ No Changeset found

Latest commit: df8b2f6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

graphite-app bot commented Oct 30, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@MananTank MananTank marked this pull request as ready for review October 30, 2024 13:47
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 30, 2024
Copy link
Member Author

MananTank commented Oct 30, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 6:58pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 30, 2024 6:58pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 30, 2024 6:58pm
wallet-ui ⬜️ Skipped (Inspect) Oct 30, 2024 6:58pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 30, 2024 13:47 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 30, 2024 13:47 Inactive
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.29%. Comparing base (950ce60) to head (df8b2f6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5234   +/-   ##
=======================================
  Coverage   45.29%   45.29%           
=======================================
  Files        1068     1068           
  Lines       55380    55380           
  Branches     3975     3975           
=======================================
  Hits        25082    25082           
  Misses      29606    29606           
  Partials      692      692           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 950ce60
packages 40.30% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Oct 30, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43 KB (0%) 861 ms (0%) 3.7 s (-4.03% 🔽) 4.5 s
thirdweb (cjs) 102.91 KB (0%) 2.1 s (0%) 7 s (+4.83% 🔺) 9 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 176 ms (-60.26% 🔽) 272 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 92 ms (-3% 🔽) 102 ms
thirdweb/react (minimal + tree-shaking) 17.38 KB (0%) 348 ms (0%) 390 ms (-8.33% 🔽) 737 ms

@MananTank MananTank changed the base branch from 10-30-fix_theming_class_hydration_warning_on_html_element to graphite-base/5234 October 30, 2024 16:35
@MananTank MananTank force-pushed the 10-30-fix_enum_lint_warning_in_dashboard branch from ba2e622 to 0d8a714 Compare October 30, 2024 16:40
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 30, 2024 16:40 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 30, 2024 16:40 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 30, 2024 16:40 Inactive
@MananTank MananTank changed the base branch from graphite-base/5234 to main October 30, 2024 16:40
@MananTank MananTank force-pushed the 10-30-fix_enum_lint_warning_in_dashboard branch from 0d8a714 to b6446e0 Compare October 30, 2024 16:40
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 30, 2024 16:40 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 30, 2024 16:40 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 30, 2024 16:40 Inactive
Copy link

graphite-app bot commented Oct 30, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR refactors the code to replace the usage of `AccountStatus` and `AccountPlan` enums with `accountStatus` and `accountPlan` constants, improving consistency and clarity throughout the codebase.

### Detailed summary
- Replaced `AccountStatus` enum with `accountStatus` constant object.
- Replaced `AccountPlan` enum with `accountPlan` constant object.
- Updated all references to use `accountStatus` and `accountPlan` instead of enums.
- Adjusted conditions and logic to align with the new structure.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 10-30-fix_enum_lint_warning_in_dashboard branch from b6446e0 to df8b2f6 Compare October 30, 2024 18:48
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 30, 2024 18:48 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 30, 2024 18:48 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 30, 2024 18:48 Inactive
@graphite-app graphite-app bot merged commit df8b2f6 into main Oct 30, 2024
28 checks passed
@graphite-app graphite-app bot deleted the 10-30-fix_enum_lint_warning_in_dashboard branch October 30, 2024 18:58
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 30, 2024 18:58 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 30, 2024 18:58 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 October 30, 2024 18:58 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants