optimize: improve mintAdditionalSupplyTo efficiency #5148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2fdb69d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @joaquim-verges and the rest of your teammates on |
size-limit report 📦
|
jnsdls
approved these changes
Oct 23, 2024
joaquim-verges
force-pushed
the
optimize_improve_mintAdditionalSupplyTo_efficiency
branch
from
fd70dd6
to
772a0ad
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5148 +/- ##
=======================================
Coverage 45.41% 45.42%
=======================================
Files 1065 1065
Lines 55149 55145 -4
Branches 3970 3970
=======================================
+ Hits 25047 25049 +2
+ Misses 29410 29404 -6
Partials 692 692
*This pull request uses carry forward flags. Click here to find out more.
|
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on optimizing the `mintAdditionalSupplyTo` function in the `erc1155` extension by modifying how the token URI is handled during the minting process.
### Detailed summary
- Removed the retrieval of the existing token URI from the contract.
- Set the `uri` field to an empty string, indicating the contract will maintain the existing token URI.
- Kept the `to`, `tokenId`, and `amount` fields unchanged.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
joaquim-verges
force-pushed
the
optimize_improve_mintAdditionalSupplyTo_efficiency
branch
from
772a0ad
to
2fdb69d
Compare
graphite-app
bot
deleted the
optimize_improve_mintAdditionalSupplyTo_efficiency
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on optimizing the
mintAdditionalSupplyTofunction in theerc1155extension of thethirdwebSDK by simplifying the handling of the token URI.Detailed summary
mintAdditionalSupplyTofunction to remove the retrieval of the existing token URI.urifield to an empty string, indicating that the contract will maintain the existing token URI.to,tokenId, andamountunchanged.