enfore more lint rules

[jnsdls]

does what it says on the tin

[changeset-bot]

⚠️ No Changeset found

Latest commit: a2b4daa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 23, 2024 4:20pm
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 23, 2024 4:20pm
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 23, 2024 4:20pm
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 23, 2024 4:20pm

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[jnsdls]

• enfore more lint rules #4754 👈
• knip it in the... #4751
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jnsdls and the rest of your teammates on Graphite

[github-actions]

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	41.91 KB (+0.04% 🔺)	839 ms (+0.04% 🔺)	355 ms (+0.36% 🔺)	1.2 s
thirdweb (cjs)	101.43 KB (+0.06% 🔺)	2.1 s (+0.06% 🔺)	886 ms (+17.87% 🔺)	3 s
thirdweb (minimal + tree-shaking)	4.82 KB (0%)	97 ms (0%)	104 ms (+187.93% 🔺)	200 ms
thirdweb/chains (tree-shaking)	498 B (0%)	10 ms (0%)	21 ms (+76.7% 🔺)	31 ms
thirdweb/react (minimal + tree-shaking)	16.73 KB (0%)	335 ms (0%)	181 ms (+181.94% 🔺)	516 ms

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.07%. Comparing base (b85fe2a) to head (a2b4daa).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4754      +/-   ##
==========================================
+ Coverage   49.04%   49.07%   +0.02%     
==========================================
  Files        1055     1054       -1     
  Lines       56888    56846      -42     
  Branches     3891     3888       -3     
==========================================
- Hits        27903    27896       -7     
+ Misses      28352    28317      -35     
  Partials      633      633              

Flag	Coverage Δ		*Carryforward flag
legacy_packages	65.68% <ø> (ø)		Carriedforward from b85fe2a
packages	45.14% <ø> (+0.02%)	⬆️

*This pull request uses carry forward flags. Click here to find out more.

see 15 files with indirect coverage changes

[MananTank]

I recently filed a bug in biome about useSortedClasses rule - It formats concatenated classes in template strings incorrectly - so need to watch out for that

biomejs/biome#4041

[MananTank]

Need to fix wrong formatting done by biome on template strings. Honestly I don't feel comfortable using useSortedClasses because of this

resolved

[graphite-app]

Merge activity

• Sep 23, 12:15 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

[graphite-app]

Merge activity

• Sep 23, 12:15 PM EDT: jnsdls added this pull request to the Graphite merge queue.
• Sep 23, 12:21 PM EDT: jnsdls merged this pull request with the Graphite merge queue.