Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ReactNative): respect icon theme color in wallet UI #4752

Merged

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Sep 22, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on respecting the icon theme color in the connect button and detail modal in React Native.

Detailed summary

  • Updated WalletImage.tsx to pass the theme color to the RNImage component for the connect button and detail modal.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Sep 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2024 10:57pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2024 10:57pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2024 10:57pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2024 10:57pm

Copy link

changeset-bot bot commented Sep 22, 2024

🦋 Changeset detected

Latest commit: 252b404

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
thirdweb Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

graphite-app bot commented Sep 22, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43.67 KB (0%) 874 ms (0%) 3 s (+16.89% 🔺) 3.9 s
thirdweb (cjs) 101.2 KB (0%) 2.1 s (0%) 6 s (+0.72% 🔺) 8 s
thirdweb (minimal + tree-shaking) 4.85 KB (0%) 98 ms (0%) 210 ms (-28.78% 🔽) 308 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 133 ms (+136.47% 🔺) 143 ms
thirdweb/react (minimal + tree-shaking) 16.72 KB (0%) 335 ms (0%) 441 ms (+1.8% 🔺) 776 ms

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.92%. Comparing base (d936d4e) to head (252b404).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4752      +/-   ##
==========================================
- Coverage   48.92%   48.92%   -0.01%     
==========================================
  Files        1050     1050              
  Lines       57002    57002              
  Branches     3892     3888       -4     
==========================================
- Hits        27889    27888       -1     
- Misses      28480    28481       +1     
  Partials      633      633              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from d936d4e
packages 44.97% <ø> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 4 files with indirect coverage changes

@joaquim-verges joaquim-verges merged commit e9ae980 into main Sep 22, 2024
31 checks passed
@joaquim-verges joaquim-verges deleted the feat_ReactNative_respect_icon_theme_color_in_wallet_UI branch September 22, 2024 23:56
@jnsdls jnsdls mentioned this pull request Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant