Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove permissions form field in ecosystem partners page + UI adjusments #4747

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Sep 21, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR removes unnecessary permissions and refactors UI components in the dashboard ecosystem feature.

Detailed summary

  • Removed unnecessary PartnerPermission export
  • Updated UI components in the dashboard layout
  • Refactored hooks for updating and adding partners
  • Updated UI components for partner-related modals and dialogs

The following files were skipped due to too many changes: apps/dashboard/src/app/(dashboard)/dashboard/connect/ecosystem/[slug]/(active)/components/client/add-partner-form.client.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel vercel bot temporarily deployed to Preview – docs-v2 September 21, 2024 22:25 Inactive
Copy link

vercel bot commented Sep 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 21, 2024 10:54pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Sep 21, 2024 10:54pm
thirdweb_playground ⬜️ Skipped (Inspect) Sep 21, 2024 10:54pm
wallet-ui ⬜️ Skipped (Inspect) Sep 21, 2024 10:54pm

Copy link

changeset-bot bot commented Sep 21, 2024

⚠️ No Changeset found

Latest commit: d936d4e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 21, 2024 22:25 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 21, 2024 22:25 Inactive
@MananTank MananTank marked this pull request as ready for review September 21, 2024 22:25
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Sep 21, 2024
Copy link

graphite-app bot commented Sep 21, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.92%. Comparing base (bc72883) to head (d936d4e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4747   +/-   ##
=======================================
  Coverage   48.92%   48.92%           
=======================================
  Files        1050     1050           
  Lines       57002    57002           
  Branches     3892     3892           
=======================================
  Hits        27889    27889           
  Misses      28480    28480           
  Partials      633      633           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from bc72883
packages 44.97% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Sep 21, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43.67 KB (0%) 874 ms (0%) 2.9 s (-0.27% 🔽) 3.8 s
thirdweb (cjs) 101.2 KB (0%) 2.1 s (0%) 5.4 s (-10.96% 🔽) 7.5 s
thirdweb (minimal + tree-shaking) 4.85 KB (0%) 98 ms (0%) 510 ms (+76.88% 🔺) 607 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 167 ms (+46.16% 🔺) 177 ms
thirdweb/react (minimal + tree-shaking) 16.72 KB (0%) 335 ms (0%) 636 ms (+12.38% 🔺) 970 ms

@MananTank MananTank force-pushed the 09-22-remove_permissions_form_field_in_ecosystem_partners_page_ui_adjusments branch from c920627 to b44970b Compare September 21, 2024 22:31
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 21, 2024 22:31 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 21, 2024 22:31 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 21, 2024 22:31 Inactive
@MananTank MananTank force-pushed the 09-22-remove_permissions_form_field_in_ecosystem_partners_page_ui_adjusments branch from b44970b to 65309cb Compare September 21, 2024 22:35
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 21, 2024 22:35 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 21, 2024 22:35 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 21, 2024 22:35 Inactive
Copy link

graphite-app bot commented Sep 21, 2024

Merge activity

…nts (#4747)

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR removes unused code related to partner permissions and updates UI components in the dashboard ecosystem section.

### Detailed summary
- Removed unused `PartnerPermission` type and related code
- Updated UI components in the dashboard ecosystem section for better user experience

> The following files were skipped due to too many changes: `apps/dashboard/src/app/(dashboard)/dashboard/connect/ecosystem/[slug]/(active)/components/client/add-partner-form.client.tsx`

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 09-22-remove_permissions_form_field_in_ecosystem_partners_page_ui_adjusments branch from 65309cb to d936d4e Compare September 21, 2024 22:51
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 21, 2024 22:51 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 21, 2024 22:51 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 21, 2024 22:51 Inactive
@graphite-app graphite-app bot merged commit d936d4e into main Sep 21, 2024
30 checks passed
@graphite-app graphite-app bot deleted the 09-22-remove_permissions_form_field_in_ecosystem_partners_page_ui_adjusments branch September 21, 2024 22:55
@vercel vercel bot temporarily deployed to Production – wallet-ui September 21, 2024 22:55 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground September 21, 2024 22:55 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 September 21, 2024 22:55 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants