Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RoyaltyPayments: fix check for royalty amount #599

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

kumaryash90
Copy link
Member

Correctly handle the case where royalty amount is equal to total amount (incl both zero)

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2568498) 64.08% compared to head (5c7d5ee) 64.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #599   +/-   ##
=======================================
  Coverage   64.08%   64.08%           
=======================================
  Files         215      215           
  Lines        6632     6632           
=======================================
  Hits         4250     4250           
  Misses       2382     2382           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kumaryash90 kumaryash90 merged commit 17c10d4 into main Jan 12, 2024
7 of 8 checks passed
@kumaryash90 kumaryash90 deleted the yash/royalty-payments-fix branch January 12, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant