Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Whole website JavaScript Projects Showcase with Search and Admin Update Functionality #956

Merged
merged 7 commits into from
Oct 15, 2023

Conversation

JayeshYadav99
Copy link
Contributor

@JayeshYadav99 JayeshYadav99 commented Oct 15, 2023

Developer Checklist

  • [ x] Followed guidelines mentioned in the readme file.
  • Followed directory structure. (e.g. ProjectName/{USERNAME}/...yourfiles)
  • Starred ⭐ the Repo (Optional)

Pull Request Title: Added JavaScript Projects Showcase with Search and Admin Update Functionality
Issue:#942
Description:
This pull request introduces a new feature to our website that showcases various JavaScript projects. It includes a search feature to easily find specific projects. Additionally, an admin update functionality has been implemented to allow administrators to add new projects via the /Update route.

Changes Made:

  • Added a new page to showcase JavaScript projects.
  • Implemented a search functionality to quickly find projects by name or keyword.
  • Introduced an admin update route /Update for adding new projects.
  • Enhanced the user interface for a seamless experience.
    Here is deployed url:
    https://testing-website-three.vercel.app/
    please see

Screenshots:

Video

Javascript.Mini-Projects.-.Google.Chrome.2023-10-15.20-29-39.mp4

Please see this video

Testing:

  • Performed extensive testing to ensure the search and admin update functionalities work as expected.
  • Tested the new feature on different devices and browsers to ensure responsiveness.
  • Verified that the admin update functionality only allows authorized users to add projects.

To-Do:

  • Add detailed documentation for the admin update route.
  • Conduct further testing for edge cases and performance optimizations.
  • Address any feedback and suggestions from the team.

Related Issues:

  • Closes #IssueNumber (if applicable)

Additional Notes:

  • This feature is expected to improve the user experience and provide better project management options for administrators.

@JayeshYadav99
Copy link
Contributor Author

@NitkarshChourasia ,please merge my pull request

Copy link
Collaborator

@PBJI PBJI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JayeshYadav99, Doesn't seems to be including the complete source code? How shall we contribute?

@PBJI PBJI merged commit 5c34413 into thinkswell:master Oct 15, 2023
@PBJI
Copy link
Collaborator

PBJI commented Oct 15, 2023

@JayeshYadav99, @PBJI, @NitkarshChourasia and @harshalhonde21 so now we have two front-ends competing with other. Opinions?

@PBJI
Copy link
Collaborator

PBJI commented Oct 15, 2023

Although I'll like to add one thing here, @JayeshYadav99 the cards are too much of a bragging and performance dropper with that animation. I think it will be much more better if it could simpler like this:

image

@NitkarshChourasia
Copy link
Collaborator

Although I'll like to add one thing here, @JayeshYadav99 the cards are too much of a bragging and performance dropper with that animation. I think it will be much more better if it could simpler like this:

image

Yes, but different people, different perspectives.
But, that is very brightening, gives a feeling of celebration.

@NitkarshChourasia
Copy link
Collaborator

What stacks and frameworks were used? @JayeshYadav99?? @PBJI?

@PBJI
Copy link
Collaborator

PBJI commented Oct 15, 2023

@NitkarshChourasia yes celebration wise, it looks stunning. can there be a middle ground I hope so...?😅 That doesn't catch users attention away from the projects, already hosted on the repository? UI can come later though, the real thing is to make it automatic and self-sufficient project that doesn't need to be maintained much once developed.

Functionality > Aesthetics in the start. But you know one thing, if a team of completely co-operative members work then both can go hand in hand. That's idealistic but yet compelling, haha anyways. I think React + Vite is the tech stack used with tailwind as css framework, here.

@NitkarshChourasia
Copy link
Collaborator

To be honest. I don't know what is doing what!
I am here, like a employee in a big service company.
Just hanging around, team lead says to incorporate into the project.
And yet he does it.

  • I don't know who is leading.
  • Who is assigned what.
  • Don't know the tech stack.
  • Not even a suggestion, for what and what not.
  • No documentation or README.md of requirements, and implemented.
  • Where is SPM methods?!
  • Requirements are not clearly set. What is needed is not know.
  • CLEAR requirements are missing.
  • If not the project is delaying. Because I haven't touched anything except reviews, that too avoided.

@NitkarshChourasia
Copy link
Collaborator

@PBJI @harshalhonde21

@PBJI
Copy link
Collaborator

PBJI commented Oct 16, 2023

@NitkarshChourasia but who told you to play that role? We are not big company, I guess it is more sensible to treat ourselves as a startup and being in a start up you need to be self-starting instead of being baby sitted.😂

For tech stack I already have specified what we are using, you should read the README.md of the main repo, there @harshalhonde21 have stuck the badges for each tech. From those most important ones for frontend are:

ReactJS, React Route, Material UI, Vite.

Rest is upon how you research about them.

Also you were assigned to make the Contacts Component.

@harshalhonde21
Copy link
Contributor

@PBJI true 🤣

@PBJI
Copy link
Collaborator

PBJI commented Oct 16, 2023

@NitkarshChourasia look I totally understand your intention but you need to understand that we are not using the waterfall method. We are using the agile model, where requirements are all creeping up with time, so you have to be in that mood yourself to truly be able to contribute any hard-coding. Currently I am working on Projects.jsx, there I first thought to add the cards that represent the existing project categories becauseI imagined that the users might need some functionality to click on it and choose from the various instances of the project contributed in each category. So now my aim is to implement that feature.

So the development is going with the user in mind. That is the best advice I can give you, develop the app with the user in mind. They need to be comfortable enough to explore the projects and also this project needs to be dynamic enough to incorporate new mini projects added to repo. How we will do this, what will be used? Is a matter of research. If we ourselves understood the requirements properly then why would we wait to implement it all of it.

@NitkarshChourasia
Copy link
Collaborator

@PBJI So, got it. Thanks.
@harshalhonde21 Will reserach first.
Okay. Thanks.
This clearity wasn't there also.
At least this is better then before.
Because, this gives me the sense that I am free to implement the best features.
I was in a sense that you guys are leading, and I am following the leads.

@NitkarshChourasia
Copy link
Collaborator

@PBJI I was in a miunderstanding that, we are working in that way, the way I said, last night.
But, thanks for clearity as how we are working, I thought the other way around the way I said before so.
So, that's where the misunderstanding was arising from.
Thank you so much, though, @PBJI .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants