Cleanup1 #997
Closed
Cleanup1 #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 20, 2020 22:59
Drop the unused parts, elements which do not actually occur in generated epubs. Further, reduce the image size and move it to the right, so that screen-real-estate is not wasted. Signed-off-by: Martin Pohlack <[email protected]>
This allows to sensible group multiple recipes in a book, and enables a structured table-of-content. The first category, in the absence of another mechanism, is treated specially to primarily group recipes. It is the first sorting criteria and primary section entries are generated per first category. Secondary sorting criteria is still the recipe name. Signed-off-by: Martin Pohlack <[email protected]>
Unit detection was not considering localization in two places. Fix the simple issue in find_errors_in_progress() by translating units to compare against. The second error is more complex, details are in thinkle#931. Disable broken parsing of number words for now. Signed-off-by: Martin Pohlack <[email protected]>
|
Thank you for submitting this pull request. I see you are a first time contributor. Welcome to Gourmet! At this time we are actively migrating Gourmet to Python 3 and Gtk 3 at kirienko/gourmet. I'm therefore holding off merging minor PRs into thinkle/gourmet master for now. A couple requests:
Adhering to the above will make the PR review smoother and the acceptance of the PR easier. Thank you for your support. |
Open
|
Thanks for the feedback. I will split things up. Do you have a rough ETA for the Python 3 and Gtk 3 conversions? Should I rather submit against kirienko/gourmet for the time being? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please consider pulling these smaller clean-ups, bugfixes, and a feature for the epub generator.