FastBingTileGenerator for significantly speeding up grid generation
#245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
joshuacortez
changed the title
FastBingTileGenerator for significantly speeding up grid generationFastBingTileGenerator for significantly speeding up grid generation [WIP]
joshuacortez
changed the title
FastBingTileGenerator for significantly speeding up grid generation [WIP]FastBingTileGenerator for significantly speeding up grid generation
joshuacortez
changed the title
FastBingTileGenerator for significantly speeding up grid generationFastBingTileGenerator for significantly speeding up grid generation
butchtm
reviewed
Aug 8, 2024
butchtm
approved these changes
Aug 8, 2024
…rangler_scanline_gridding into feat/scanline_gridding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new gridding class
FastBingTileGeneratorthat significantly speeds up grid generation. This is added in00_grids.ipynb.FastBingTileGeneratorleverages the voxel traversal algorithm and the scanline fill algorithm to get all pixels given the vertices of a polygon. The utility functions for these algorithms are defined in15_polygon_fill.ipynbwith corresponding examples.Reviewers should look at the ff notebooks
00_grids.ipynb15_polygon_fill.ipynbtutorial.grids.ipynbRemaining To-dos:
FastBingTileGeneratorFeedback is appreciated!