-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exactextract Tutorial #241
Exactextract Tutorial #241
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Hi @tm-jc-nacpil! Lgtm 😄 just wondering why the output wasn't save for Bing Tile Grid Tile AOIs (exactextract).
Sounds good! Maybe we can have a separate notebook for the benchmarking.
Not sure if other Geo are using weighted statistics so we can put this on low prio for now unless if you already have a use case for it.
You can add a brief note in the tutorial notebook on how to use them or describe sample use cases. |
@@ -114,7 +114,7 @@ | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the catch! fixed in the latest commit :D
Latest commit adds the ff.!
|
@@ -354,8 +354,8 @@ | |||
"name": "stdout", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line #2. # Single band
This cell and the next one seem to be both effectively single band with multiple aggregations. You could
- Remove this cell
- Call this as
Single band with single aggregation
and then only use onefunc
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the catch, makes sense! let's go with number 2 :D
@@ -114,7 +114,7 @@ | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could change the heading to Comparison of exactextract
and rasterstats
in general since you talk about the recommendations and percent difference later on.
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in latest commit!
The tutorial looks great! 😄 Just have some alternate suggestions for a few parts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Adds tutorial for exactextract zonal stats as a new section at the end of the current notebook
So far, I've written the ff.
Things I think we could add -- lmk your thoughts on this!