Reading the Balance port (if present) #49
Conversation
… do the check if the adc is present
| @@ -14,6 +14,9 @@ namespace CONFIG { | |||
|
|
|||
| #define CURRENT_CHALLENGE ESCAPE_ROUTE | |||
|
|
|||
| constexpr int I2C_SDA_PIN = 20; | |||
There was a problem hiding this comment.
pimoroni/pimoroni-pico#890 is merged into pimoroni-pico:main now - i wonder if we can use the MOTOR2040 namespace config values now? Assuming that they're compatible with the pins on our board of course...
| #include <string> | ||
| #include "pico/stdlib.h" | ||
| #include "hardware/i2c.h" | ||
| #include "ads1x15.h" |
There was a problem hiding this comment.
it might be a bit of a stretch goal, but having a balance port library that isn't tightly coupled to the ADC hardware would be useful, as it would mean that it was portable between projects. It would also mean that we had a portable ADS1x15 library to use on other RP2040 projects for reasons other than specifically checking the balance port. realistically that would mean seperating the ADS1x15 and the balance_port libraries, and probably some kind of adaptor pattern interface so that different ADC drivers could be used. Probably not critical to go the whole hog for now, but worth at least doing the library separation.
There was a problem hiding this comment.
ADS1x15 is now a seperate (external) library, but the balance_port library is still tightly coupled to it.
libs/receiver/src/receiverCPPM.cpp
Outdated
| @@ -36,6 +36,6 @@ ReceiverChannelValues ReceiverCPPM::get_channel_values() const { | |||
| } | |||
|
|
|||
| bool ReceiverCPPM::get_receiver_data() const { | |||
| return decoder->getFrameAgeMs() > 0; | |||
| return decoder->getFrameAgeUs() > 0; | |||
There was a problem hiding this comment.
is this change related to the balance port checking?
There was a problem hiding this comment.
no, but it was needed to get my code to compile. This change is now on main. I'd cherrypicked the commit from #48 , so expected this change to disappear with a rebase. I've now rebased, but it's made it worse, we now appear to have two commits making this change! I'm confused.
… do the check if the adc is present
… do the check if the adc is present
* rename `getCellStatus` -> `raiseCellStatus` * raise printf calls within method body * make it a void function
hijack the 20ms timer in the main loop to check battery voltages every 2s
…y passing in user data
seems to work well. gives a useful message if there's a problem. Currently the program doesn't change behaviour if there's a problem though.