Update Arduino_MQTT_Client.h #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed TBPubSubClient.h to PubSubClient to be compatible with PubSubClient (ThingsBoard) release v2.9.3
|
@spirosbond Sorry for the late reply. I added in the review below what should be done as well, would be nice if you could integrate that change. @imbeacon Would be nice if this could be merged and released as Fixes #165. |
MathewHDYT
suggested changes
Dec 6, 2023
There was a problem hiding this comment.
Bump the version number to v0.12.1, has to be done in the idf_component.yml file, the library.json file and the library.properties file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed TBPubSubClient.h to PubSubClient to be compatible with PubSubClient (ThingsBoard) release v2.9.3