Backport bugfixes from v0.12.0 #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@imbeacon It seems you missed to create a GitHub release for |
|
Hi, @MathewHDYT , I think we can just merge this PR and create a version v0.11.0 , what do you think about this? |
|
@imbeacon That would be a bad idea, because PlatformIO and ArduinoIDE have the latest tag being v0.11.0. That is the case because the internal version file changed. Therefore the best thing would be simply creating a release for v0.11.0 on GitHub. Meaning the current state of the repository and then merging this Pull Request. And creating a new version v0.11.1 on GitHub. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typo with
ESP6266_Updater.cppand missing implementation ofIUpdaterinterface inOTA_Handler, causing compile issues with some devices.Additionally the need to resubscribe when reconnecting with
ThingsBoardhas been removed, because that is now done automatically in the background. Meaning the Subscribe portion only has to be called once at startup and can then be ignored.The cleanup functionality if still desired has been moved to another method
Cleanup_Subscriptions, which will have the same behaviour as reconnecting previously did.Additionally receiving
RPCthen receivingShared Attribute Updatesthenrequesting attributesall work perfectly even when used interchangeably.@imbeacon Would be nice if this could be merged and released as v0.11.1