-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Simplify command state update methods #3309
refactor: Simplify command state update methods #3309
Conversation
Codecov ReportAttention: Patch coverage is Additional details and impacted files📢 Thoughts on this report? Let us know! |
Robot Results
|
@@ -410,14 +402,14 @@ impl WorkflowRepository { | |||
operation: &OperationType, | |||
command_state: GenericCommandState, | |||
) -> Result<Option<GenericCommandState>, WorkflowExecutionError> { | |||
let operation_name = operation.to_string(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: I think to_owned
better signifies the intent here
let operation_name = operation.to_string(); | |
let operation_name = operation.to_owned(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to_owned()
is not appropriate here.
To convey the intent, I replaced to_string()
by name()
: 33268b9
Signed-off-by: Didier Wenzek <[email protected]>
Signed-off-by: Didier Wenzek <[email protected]>
In order to better convey the intent. Signed-off-by: Didier Wenzek <[email protected]>
33268b9
to
b9fea1b
Compare
Proposed changes
Address comments raised on #3307
Types of changes
Paste Link to the issue
#3307
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments