Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graceful stop #98

Merged
merged 6 commits into from
Jan 25, 2024
Merged

Graceful stop #98

merged 6 commits into from
Jan 25, 2024

Conversation

Dashboy1998
Copy link
Contributor

Context

  • Add in graceful stop

Choices

Test instructions

  1. Run with RCON_ENABLED=true
  2. Join the game and move to a different location in game
  3. Stop the container with ctrl + c
  4. Restart container and join game again to verify it saved where you ended
  5. Repeat 1 - 3 with RCON_ENABLED=false NOTE: this does not save without rcon

Checklist before requesting a review

  • I have performed a self-review of my code
  • I've added documentation about this change to the README.
  • I've not introduced breaking changes.

@thijsvanloef thijsvanloef linked an issue Jan 25, 2024 that may be closed by this pull request
@thijsvanloef
Copy link
Owner

Thank you for the PR! I will check it once I get home from work :D

@thijsvanloef thijsvanloef added the enhancement New feature or request label Jan 25, 2024
@thijsvanloef
Copy link
Owner

Amazing work, made a small tweak, ready to merge :)

@thijsvanloef thijsvanloef merged commit eb18e67 into thijsvanloef:main Jan 25, 2024
4 checks passed
This was referenced Jan 26, 2024
@Dashboy1998 Dashboy1998 deleted the graceful-stop branch January 28, 2024 12:46
MusclePr pushed a commit to MusclePr/palworld-server-docker that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stopping does not appear to be graceful
2 participants