-
-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: added basic yamls for kubernetes support. #65
Conversation
@thijsvanloef It seems to be working without my initContainer updating the permissions. Whether it's due to just needing a one time update or not is unknown. I would say that it's safe to merge though. |
Thx people :-) I have changed everything as requested. Realy good suggestions you guys made :-) much appreciated. |
Have you thought about usage of |
Just thinking out loud, maybe also adding a cronjob resource for backing stuff up? Out of scope? |
I would suggest we finish this PR and iterate from there on. Otherwise this is gonne be a never ending PR ;-) |
Nice work all 💪! @beneiltis should I wait before I merge this as @cdrage and @alex4108 are still pending reviewers, or are you confident? |
@thijsvanloef you can merge it from my point of view. I have modified all parts according to the guys suggestions. I also tried all manifests on my own server. everything works great. |
Yes, sir! =) Good job anyways. |
name: palworld-secrets | ||
type: Opaque | ||
stringData: | ||
rconPassword: yourRconPassword |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"yourRconPassword in base64 format" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's plaintext in the manifest files. It's base64 if you kubectl describe
though.
I usually call it something like example.secret.yaml
, make a copy, put the actual password in, apply the yaml with kubectl apply -f secrets.yaml
then rm secrets.yaml
.
Awesome, once again thank you for your work @beneiltis! |
Confirm it works my side too, awesome work @beneiltis :) |
fix: added basic yamls for kubernetes support.
Just added support for kubernetes. We can use this as a starting point. I run it like this in my cluster and it works like a charm. Thx for the nice work @thijsvanloef