Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added basic yamls for kubernetes support. #65

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

beneiltis
Copy link
Contributor

Just added support for kubernetes. We can use this as a starting point. I run it like this in my cluster and it works like a charm. Thx for the nice work @thijsvanloef

@thijsvanloef thijsvanloef self-requested a review January 23, 2024 09:54
@thijsvanloef
Copy link
Owner

@Slyke are you able to confirm that this fixes #63?

k8s/deployment.yaml Outdated Show resolved Hide resolved
@Slyke
Copy link

Slyke commented Jan 23, 2024

@Slyke are you able to confirm that this fixes #63?

Will check tonight after work.

@thijsvanloef thijsvanloef added the enhancement New feature or request label Jan 23, 2024
k8s/pvc.yaml Outdated Show resolved Hide resolved
k8s/pvc.yaml Outdated Show resolved Hide resolved
k8s/deployment.yaml Outdated Show resolved Hide resolved
k8s/deployment.yaml Outdated Show resolved Hide resolved
k8s/deployment.yaml Outdated Show resolved Hide resolved
k8s/service.yaml Outdated Show resolved Hide resolved
k8s/service.yaml Outdated Show resolved Hide resolved
k8s/service.yaml Outdated Show resolved Hide resolved
k8s/service.yaml Outdated Show resolved Hide resolved
k8s/service.yaml Outdated Show resolved Hide resolved
@thijsvanloef thijsvanloef added the help wanted Extra attention is needed label Jan 23, 2024
@thijsvanloef thijsvanloef removed their request for review January 23, 2024 20:42
@Slyke
Copy link

Slyke commented Jan 24, 2024

@thijsvanloef It seems to be working without my initContainer updating the permissions. Whether it's due to just needing a one time update or not is unknown. I would say that it's safe to merge though.

@beneiltis
Copy link
Contributor Author

Thx people :-) I have changed everything as requested. Realy good suggestions you guys made :-) much appreciated.
I have checked it with my setup and it is still working great. Ready for merge :-)

@beneiltis beneiltis requested review from alex4108 and cdrage January 24, 2024 08:12
@elonmir
Copy link

elonmir commented Jan 24, 2024

Have you thought about usage of kustomization, then you could roll it out with a single apply command.

@elonmir
Copy link

elonmir commented Jan 24, 2024

Just thinking out loud, maybe also adding a cronjob resource for backing stuff up? Out of scope?

@beneiltis
Copy link
Contributor Author

I would suggest we finish this PR and iterate from there on. Otherwise this is gonne be a never ending PR ;-)

@thijsvanloef
Copy link
Owner

Nice work all 💪! @beneiltis should I wait before I merge this as @cdrage and @alex4108 are still pending reviewers, or are you confident?

@beneiltis
Copy link
Contributor Author

@thijsvanloef you can merge it from my point of view. I have modified all parts according to the guys suggestions. I also tried all manifests on my own server. everything works great.

@elonmir
Copy link

elonmir commented Jan 24, 2024

I would suggest we finish this PR and iterate from there on. Otherwise this is gonne be a never ending PR ;-)

Yes, sir! =) Good job anyways.

name: palworld-secrets
type: Opaque
stringData:
rconPassword: yourRconPassword

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"yourRconPassword in base64 format" ?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's plaintext in the manifest files. It's base64 if you kubectl describe though.

I usually call it something like example.secret.yaml, make a copy, put the actual password in, apply the yaml with kubectl apply -f secrets.yaml then rm secrets.yaml.

@thijsvanloef
Copy link
Owner

Awesome, once again thank you for your work @beneiltis!

@thijsvanloef thijsvanloef merged commit 551c6b1 into thijsvanloef:main Jan 24, 2024
3 checks passed
@cdrage
Copy link

cdrage commented Jan 24, 2024

Confirm it works my side too, awesome work @beneiltis :)

MusclePr pushed a commit to MusclePr/palworld-server-docker that referenced this pull request Jun 19, 2024
fix: added basic yamls for kubernetes support.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants