Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excluding game backup folder in our backup. #524

Merged

Conversation

Dashboy1998
Copy link
Contributor

Context

This change means backup will no longer copy the games backup #520

Choices

Simply using --exclude backup to exclude the backup folder as there are no other files or folders named backup in the Saved directory.

Alternative Choice

I had considered using find to so reduce the possibility of excluding the wrong files/directories if any were named backup however decided against this would be addressing an issue that the user must create.

Test instructions

  1. Ideal up the game using the latest image
  2. Backup again using the this PR
  3. Verify this PR backup has no backup directory inside of it.

Checklist before requesting a review

  • I have performed a self-review/test of my code
  • [] I've added documentation about this change to the docs.
  • I've not introduced breaking changes.
  • My changes do not violate linting rules.

@thijsvanloef thijsvanloef merged commit 5ec3b03 into thijsvanloef:main Apr 5, 2024
10 checks passed
MusclePr pushed a commit to MusclePr/palworld-server-docker that referenced this pull request Jun 19, 2024
…r-0.2.0.6

Excluding game backup folder in our backup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants