Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug that displays start when server has been stopped #486

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

thijsvanloef
Copy link
Owner

Context

Fix 485

The server stop messages was titled: "Start". Now correctly titled: "Stop"

Choices

Test instructions

Checklist before requesting a review

  • I have performed a self-review of my code
  • I've added documentation about this change to the README.
  • I've not introduced breaking changes.

@thijsvanloef thijsvanloef added the bug Something isn't working label Mar 3, 2024
@thijsvanloef thijsvanloef self-assigned this Mar 3, 2024
@thijsvanloef thijsvanloef linked an issue Mar 3, 2024 that may be closed by this pull request
@xHyperElectric
Copy link
Contributor

You beat me to it, I was submitting a PR now. I'm very new to this and didn't know if submitting an issue first and then a PR or just a PR immediately was proper etiquette.

@thijsvanloef
Copy link
Owner Author

@xHyperElectric Both are fine! would benefit from a small message stating that you are fixing it right now, so we don't do double the work ;)

@xHyperElectric
Copy link
Contributor

would benefit from a small message stating that you are fixing it right now, so we don't do double the work ;)

Noted!

@thijsvanloef thijsvanloef merged commit 1fd3325 into main Mar 3, 2024
10 checks passed
@thijsvanloef thijsvanloef deleted the fix-stop-message branch March 3, 2024 18:54
MusclePr pushed a commit to MusclePr/palworld-server-docker that referenced this pull request Jun 19, 2024
fix bug that displays start when server has been stopped
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discord server stopping message has a title of "Start"
2 participants