Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Engine.ini based on ENV vars #454

Merged
merged 4 commits into from
Feb 27, 2024
Merged

Conversation

thijsvanloef
Copy link
Owner

Context

Fixes #257 #176
Enable users to generate the Engine.ini using evironment variabels

Choices

Using the same method as compile-settings.sh, compile the engine settings.

Test instructions

  1. Build the container
  2. set DISABLE_GENERATE_ENGINE to false
  3. check that ./palworld/Pal/Saved/Config/LinuxServer/engine.ini has been updated

Checklist before requesting a review

  • I have performed a self-review of my code
  • I've added documentation about this change to the docusaurus.
  • I've not introduced breaking changes.

@thijsvanloef thijsvanloef added the enhancement New feature or request label Feb 26, 2024
@thijsvanloef thijsvanloef self-assigned this Feb 26, 2024
@thijsvanloef thijsvanloef linked an issue Feb 26, 2024 that may be closed by this pull request
Copy link
Contributor

@Luatan Luatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Tested it locally and it works without issues. It think it would be good to document in the docs how to enable it tho.

Also is there a specific reason why it is disabled by default?

@thijsvanloef
Copy link
Owner Author

Looks good to me. Tested it locally and it works without issues. It think it would be good to document in the docs how to enable it tho.

Also is there a specific reason why it is disabled by default?

Mostly because of backwards compatibility, I do not want to overwrite the changes someone has made already.

Documenting the need to enable is a good one, need to do that

scripts/compile-engine.sh Show resolved Hide resolved
scripts/compile-engine.sh Show resolved Hide resolved
scripts/compile-engine.sh Show resolved Hide resolved
scripts/compile-engine.sh Show resolved Hide resolved
scripts/compile-engine.sh Show resolved Hide resolved
scripts/files/Engine.ini.template Show resolved Hide resolved
@thijsvanloef thijsvanloef merged commit 63ff093 into main Feb 27, 2024
10 checks passed
@thijsvanloef thijsvanloef deleted the engine-ini-settings branch February 27, 2024 16:45
MusclePr pushed a commit to MusclePr/palworld-server-docker that referenced this pull request Jun 19, 2024
…ings

Generate Engine.ini based on ENV vars
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Engine.ini Settings update Setting NetServerMaxTickRate via ENV
3 participants