-
-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate Engine.ini based on ENV vars #454
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Tested it locally and it works without issues. It think it would be good to document in the docs how to enable it tho.
Also is there a specific reason why it is disabled by default?
Mostly because of backwards compatibility, I do not want to overwrite the changes someone has made already. Documenting the need to enable is a good one, need to do that |
docusaurus/docs/getting-started/configuration/engine-settings.md
Outdated
Show resolved
Hide resolved
docusaurus/docs/getting-started/configuration/engine-settings.md
Outdated
Show resolved
Hide resolved
docusaurus/docs/getting-started/configuration/engine-settings.md
Outdated
Show resolved
Hide resolved
…ings Generate Engine.ini based on ENV vars
Context
Fixes #257 #176
Enable users to generate the Engine.ini using evironment variabels
Choices
Using the same method as compile-settings.sh, compile the engine settings.
Test instructions
DISABLE_GENERATE_ENGINE
tofalse
./palworld/Pal/Saved/Config/LinuxServer/engine.ini
has been updatedChecklist before requesting a review