Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove temp file on failure in update required #435

Conversation

Dashboy1998
Copy link
Contributor

Context

  • Currently when the server check for updates it create a temporary file however the file is not deleted if there is an issue retrieving the manifest id.

Choices

  • Removing file on failure

Test instructions

  1. Create server
  2. bash into the server and change the URL on line 63 in helper_install.sh to an invalid one
  3. list files in ls /tmp
  4. Run update
  5. Verify there is no tmp file in ls /tmp

Checklist before requesting a review

  • I have performed a self-review of my code
  • I've added documentation about this change to the README.
  • I've not introduced breaking changes.

@thijsvanloef thijsvanloef merged commit 11a8f9a into thijsvanloef:main Feb 23, 2024
10 checks passed
MusclePr pushed a commit to MusclePr/palworld-server-docker that referenced this pull request Jun 19, 2024
…update-required-if-error

Remove temp file on failure in update required
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants