Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix PUBLIC_PORT #390

Merged
merged 1 commit into from
Feb 14, 2024
Merged

fix PUBLIC_PORT #390

merged 1 commit into from
Feb 14, 2024

Conversation

MusclePr
Copy link
Contributor

@MusclePr MusclePr commented Feb 14, 2024

Context

Choices

  • PUBLIC_PORT is different from PORT.

Test instructions

  • run following test.sh
#!/bin/bash
if [ ! -f docker-compose.override.yml ]; then
cat > docker-compose.override.yml <<EOF
services:
  palworld:
    environment:
      PUBLIC_PORT: 8212
    healthcheck:
      test: rcon-cli info
EOF
fi
docker compose up -d
echo -n "wait healthy"
while [ ! "$(docker inspect palworld-server -f '{{.State.Health.Status}}')" = "healthy" ]; do
        sleep 1
        echo -n "."
done
echo " done."
docker compose down
sed -nre 's/.*(PublicPort=\w+).*/\1/p' palworld/Pal/Saved/Config/LinuxServer/PalWorldSettings.ini

Checklist before requesting a review

  • I have performed a self-review of my code
  • I've added documentation about this change to the README. Fixed to work according to README.
  • I've not introduced breaking changes.

@thijsvanloef thijsvanloef merged commit 0eb68b2 into thijsvanloef:main Feb 14, 2024
8 checks passed
@MusclePr MusclePr deleted the fix/PublicPort branch February 15, 2024 02:17
MusclePr pushed a commit to MusclePr/palworld-server-docker that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants