Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix unit-test #377

Merged
merged 5 commits into from
Feb 14, 2024
Merged

fix unit-test #377

merged 5 commits into from
Feb 14, 2024

Conversation

win5923
Copy link
Contributor

@win5923 win5923 commented Feb 12, 2024 •
edited
Loading

Context

  • Add more delay time for the arm-64 unit test.
  • Using concurrency to cancel any in-progress job or run.

Choices

  • The arm-64 server startup is currently taking too long, so additional delay time is being added.
  • Using concurrency to cancel the previous push, always testing the latest push.

Test instructions

  1. Push to the main branch and check each unit test step to ensure it meets the expected criteria.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I've added documentation about this change to the README.
  • I've not introduced breaking changes.

@thijsvanloef thijsvanloef merged commit e04b34e into thijsvanloef:main Feb 14, 2024
8 checks passed
@win5923 win5923 deleted the fix-unittest branch February 14, 2024 10:47
MusclePr pushed a commit to MusclePr/palworld-server-docker that referenced this pull request Jun 19, 2024
@thijsvanloef
Merge pull request thijsvanloef#377 from win5923/fix-unittest
8f11010 
fix unit-test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@win5923 @thijsvanloef