-
-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add env to toggle to automatically generate palworldsettings #342
Add env to toggle to automatically generate palworldsettings #342
Conversation
… into toggle-generate-settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it, and works great, the only thing I would still like is a small printf that notifies the users that the ENV vars will not be applied as the DISABLE_GENERATE_SETTINGS is true
… into toggle-generate-settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
…ettings Add env to toggle to automatically generate palworldsettings
Context
resolves #326
Choices
Add an env var which is false by default that decides if the PalWorldSettings.ini is compiled from env vars automatically
Test instructions
Test Case: New Server, no automatic settings
DISABLE_GENERATE_SETTINGS
totrue
cat /palworld/Pal/Saved/Config/LinuxServer/PalWorldSettings.ini
Test Case: Existing Server, no automatic settings
DISABLE_GENERATE_SETTINGS
totrue
SERVER_NAME
environment variablecat /palworld/Pal/Saved/Config/LinuxServer/PalWorldSettings.ini
SERVER_NAME
was not appliedTest Case: New Server, automatic settings
DISABLE_GENERATE_SETTINGS
tofalse
(or remove it entirely)cat /palworld/Pal/Saved/Config/LinuxServer/PalWorldSettings.ini
Test Case: Existing Server, automatic settings
DISABLE_GENERATE_SETTINGS
tofalse
(or remove it entirely)cat /palworld/Pal/Saved/Config/LinuxServer/PalWorldSettings.ini
Checklist before requesting a review