Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File checks for config generation #334

Merged

Conversation

Dashboy1998
Copy link
Contributor

Context

Choices

  • Moved helper functions to their own script so they can be used in other scripts

Test instructions

  1. Verify the container starts as normal
  2. Remove the write permissions of the config file chmod ugo-w palworld/Pal/Saved/Config/LinuxServer/PalWorldSettings.ini
  3. Start the container and verify you get this message /palworld/Pal/Saved/Config/LinuxServer/PalWorldSettings.ini is not writable. and Unable to create /palworld/Pal/Saved/Config/LinuxServer/PalWorldSettings.ini
  4. Delete the config file and remove write permission from the directory rm -f palworld/Pal/Saved/Config/LinuxServer/PalWorldSettings.ini && chmod ugo-w palworld/Pal/Saved/Config/LinuxServer/
  5. Start the container and verify you get these messages /palworld/Pal/Saved/Config/LinuxServer is not writable. and Unable to create /palworld/Pal/Saved/Config/LinuxServer/PalWorldSettings.ini
  6. Delete the config directory and remove the write permissions of the parent folder chmod ugo+w palworld/Pal/Saved/Config/LinuxServer/ && rm -rf palworld/Pal/Saved/Config/LinuxServer/ && chmod ugo-w palworld/Pal/Saved/Config
  7. Start the container and verify you get this messages mkdir: cannot create directory '/palworld/Pal/Saved/Config/LinuxServer': Permission denied

Checklist before requesting a review

  • I have performed a self-review of my code
  • I've added documentation about this change to the README.
  • I've not introduced breaking changes.

@Dashboy1998 Dashboy1998 marked this pull request as draft February 8, 2024 18:37
@Dashboy1998 Dashboy1998 marked this pull request as ready for review February 8, 2024 18:55
@thijsvanloef thijsvanloef merged commit 57d96a4 into thijsvanloef:main Feb 9, 2024
5 checks passed
MusclePr pushed a commit to MusclePr/palworld-server-docker that referenced this pull request Jun 19, 2024
…config-generation

File checks for config generation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants